-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE, TEST cover ]Registry port support config. #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d67ea7
to
42e639c
Compare
Pull Request Test Coverage Report for Build 10199838721Details
💛 - Coveralls |
42e639c
to
fbdd33f
Compare
Signed-off-by: Lan Liang <[email protected]>
fbdd33f
to
a14d518
Compare
Seems like have some flake tests here, also reproduce on local.
|
The second problem: err: dependency 'flask-demo-kcl-manifests' not found in '/home/runner/.kcl/kpm/flask-demo-kcl-manifests_ade147b'
client_test.go:626:
Error Trace: /home/runner/work/kpm/kpm/pkg/client/client_test.go:626
Error: Not equal:
expected: *reporter.KpmEvent(&reporter.KpmEvent{errType:61, msg:"", err:(*errors.errorString)(0xc0004bbdf0)})
actual : <nil>(<nil>)
Test: TestResolveMetadataInJsonStr
client_test.go:642:
Error Trace: /home/runner/work/kpm/kpm/pkg/client/client_test.go:642
Error: Not equal:
expected: ""
actual : "{\"packages\":{\"flask_demo_kcl_manifests\":{\"name\":\"flask_demo_kcl_manifests\",\"manifest_path\":\"/home/runner/.kcl/kpm/flask-demo-kcl-manifests_ade147b\"}}}"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-
+{"packages":{"flask_demo_kcl_manifests":{"name":"flask_demo_kcl_manifests","manifest_path":"/home/runner/.kcl/kpm/flask-demo-kcl-manifests_ade147b"}}}
Test: TestResolveMetadataInJsonStr
client_test.go:651:
Error Trace: /home/runner/work/kpm/kpm/pkg/client/client_test.go:651
Error: Not equal:
expected: *reporter.KpmEvent(&reporter.KpmEvent{errType:23, msg:"could not load 'kcl.mod' in '/home/runner/work/kpm/kpm/pkg/client/test_data/resolve_metadata/vendor/flask-demo-kcl-manifests_ade147b'", err:(*fs.PathError)(0xc00071a840)})
actual : <nil>(<nil>)
Test: TestResolveMetadataInJsonStr
client_test.go:665:
Error Trace: /home/runner/work/kpm/kpm/pkg/client/client_test.go:665
Error: Not equal:
expected: ""
actual : "{\"packages\":{\"flask_demo_kcl_manifests\":{\"name\":\"flask_demo_kcl_manifests\",\"manifest_path\":\"/home/runner/work/kpm/kpm/pkg/client/test_data/resolve_metadata/vendor/flask-demo-kcl-manifests_ade147b\"}}}"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-
+{"packages":{"flask_demo_kcl_manifests":{"name":"flask_demo_kcl_manifests","manifest_path":"/home/runner/work/kpm/kpm/pkg/client/test_data/resolve_metadata/vendor/flask-demo-kcl-manifests_ade147b"}}}
Test: TestResolveMetadataInJsonStr
--- FAIL: TestResolveMetadataInJsonStr (0.00s) Let me check it tomorrow. |
Hi @liangyuanpeng 😄 Is this PR still working? If this PR becomes deprecated, we may close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make cover is running on local but failing on PR
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: