Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update formula documentation to include new fields #1230

Merged
merged 4 commits into from
Sep 26, 2023
Merged

feat: update formula documentation to include new fields #1230

merged 4 commits into from
Sep 26, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Sep 25, 2023 •
edited by zroubalik
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@JorTurFer JorTurFer requested a review from a team as a code owner September 25, 2023 23:09
@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit b42c471
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6512b83736832e00085ef458
😎 Deploy Preview https://deploy-preview-1230--keda.netlify.app/docs/2.12/concepts/scaling-deployments
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@JorTurFer JorTurFer mentioned this pull request Sep 25, 2023
Merged
4 tasks
tomkerkhove
tomkerkhove reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the "Scaling Modifiers (Experimental) " section please?

@JorTurFer
update docs
a775ce2 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

Can you also update the "Scaling Modifiers (Experimental) " section please?

sure!

@JorTurFer
add example
b42c471 
Signed-off-by: Jorge Turrado <[email protected]>
zroubalik
zroubalik approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 87d4351 into kedacore:main Sep 26, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @zroubalik @tomkerkhove