Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apache-kafka.md #1341

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Update apache-kafka.md #1341

merged 3 commits into from
Apr 7, 2024

Conversation

sameerjoshinice
Copy link
Contributor

@sameerjoshinice sameerjoshinice commented Mar 22, 2024

The value of boolean should be in single quotes , otherwise its not accepting.

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

The value of boolean should be in single quotes , otherwise its not accepting.

Signed-off-by: Sameer Joshi <[email protected]>
@sameerjoshinice sameerjoshinice requested a review from a team as a code owner March 22, 2024 13:52
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 4d306e1
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/660a2ecb68641c00086cc920
😎 Deploy Preview https://deploy-preview-1341--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! Could you update other versions as well?

Signed-off-by: Sameer Joshi <[email protected]>
Changes for adding the flag in single quotes. 

Signed-off-by: Sameer Joshi <[email protected]>
@sameerjoshinice
Copy link
Contributor Author

nice catch! Could you update other versions as well?

Updated other versions where the flag was not in quotes.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@JorTurFer JorTurFer merged commit bd99cee into kedacore:main Apr 7, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants