Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keda User Taotesting #1352

Merged
merged 3 commits into from
Apr 4, 2024
Merged

New Keda User Taotesting #1352

merged 3 commits into from
Apr 4, 2024

Conversation

rafaeltovargarrido
Copy link
Contributor

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@rafaeltovargarrido rafaeltovargarrido requested a review from a team as a code owner April 3, 2024 09:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 0717b93
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/660d4a0d5aedca0008d9850d
😎 Deploy Preview https://deploy-preview-1352--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JorTurFer JorTurFer changed the title chore: add new client New Keda User Taotesting Apr 3, 2024
@tomkerkhove
Copy link
Member

Do you have a non-white logo? It does not really render well on the page

@rafaeltovargarrido rafaeltovargarrido marked this pull request as draft April 3, 2024 12:02
@rafaeltovargarrido rafaeltovargarrido marked this pull request as ready for review April 3, 2024 12:10
@rafaeltovargarrido rafaeltovargarrido marked this pull request as draft April 3, 2024 12:14
@rafaeltovargarrido
chore: add new client
b94cbe8 
Signed-off-by: Rafael Jose Tovar Garrido <[email protected]>
@rafaeltovargarrido
chore: new logo
1c20b0d 
Signed-off-by: Rafael Jose Tovar Garrido <[email protected]>
@rafaeltovargarrido
new logo
0717b93 
Signed-off-by: Rafael Jose Tovar Garrido <[email protected]>
@rafaeltovargarrido rafaeltovargarrido marked this pull request as ready for review April 3, 2024 12:22
@rafaeltovargarrido
Copy link
Contributor Author

hello @tomkerkhove I just upload the new logo :)

tomkerkhove
tomkerkhove approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks a ton!

@tomkerkhove tomkerkhove merged commit c713894 into kedacore:main Apr 4, 2024
8 checks passed
@rafaeltovargarrido rafaeltovargarrido deleted the feat/taotesting branch April 4, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaeltovargarrido @tomkerkhove