Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document prometheus metric deprecations #1374

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Apr 16, 2024

Original work in #1258, reasons for duplicate PR kedacore/keda#5687 (comment)

Updates the docs with the changes in kedacore/keda#5174.

I merely cherry-picked the documentation changes and applied review suggestions

  • moved the docs to target 2.14
  • fixed minor typos
  • also kept original text next to the deprecated metrics right after the deprecation notice and recommendation to use new metric

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

closes: #1258

@wozniakjan wozniakjan requested a review from a team as a code owner April 16, 2024 08:04
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit c8d0835
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66210b2dda22a20008f7e551
😎 Deploy Preview https://deploy-preview-1374--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/docs/2.14/operate/prometheus.md Outdated Show resolved Hide resolved
content/docs/2.14/operate/prometheus.md Outdated Show resolved Hide resolved
@wozniakjan
Copy link
Member Author

thanks @tomkerkhove, I applied your suggestions, let me please know if there is anything else.

@zroubalik zroubalik merged commit 15efec1 into kedacore:main Apr 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants