Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct Elasticsearch index field #1465

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: Correct Elasticsearch index field #1465

merged 1 commit into from
Nov 5, 2024

Conversation

rickbrouwer
Copy link
Contributor

The documentation states that the field index is comma separated. In the code it is semicolon. This PR is to improve the documentation.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related: 6101

@rickbrouwer rickbrouwer requested a review from a team as a code owner September 5, 2024 06:45
@netlify Netlify
Copy link

netlify bot commented Sep 5, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit c35d139
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66d95ac3af03c50008d5e724
😎 Deploy Preview https://deploy-preview-1465--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@rickbrouwer rickbrouwer mentioned this pull request Sep 18, 2024
Merged
4 tasks
zroubalik
zroubalik approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zroubalik zroubalik merged commit 305c7d5 into kedacore:main Nov 5, 2024
7 checks passed
@rickbrouwer rickbrouwer deleted the elastic branch November 6, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickbrouwer @zroubalik