Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update supportedKubernetesVersions for 2.14/2.15/2.16 #1499

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chenrui333
Copy link

@chenrui333 chenrui333 commented Nov 15, 2024

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1498
relates to endoflife-date/endoflife.date#6197

@chenrui333 chenrui333 requested a review from a team as a code owner November 15, 2024 21:47
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit e3078d7
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6737c1bd2a06910008dcca6d
😎 Deploy Preview https://deploy-preview-1499--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenrui333 chenrui333 changed the title fix: update version require for 2.14/2.15/2.16 fix: update supportedKubernetesVersions for 2.14/2.15/2.16 Nov 15, 2024
> 💡 **NOTE:** KEDA requires Kubernetes cluster version 1.27 and higher
> 💡 **NOTE:** KEDA requires Kubernetes cluster version v1.27 to v1.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully sure about setting "and higher" because maybe in the future, new versions don't work because of any breaking change. I personally prefer to set versions that are officially supported (because we execute the tests against them)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, not sure either, but this aligns with the release table though

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use 1.27 - 1.31 instead of 1.27 and higher for supportedKubernetesVersions
2 participants