Fix doc link reference in setupscaler.md #1502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Struß <[email protected]>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wozniakjan
reviewed
Nov 21, 2024
| @@ -12,7 +12,7 @@ description = "Procedure to Setup a Scaler in KEDA" | |||
|
|
|||
| 2. **KEDA Installation**: | |||
| - KEDA needs to be installed on your Kubernetes cluster before you can use it. | |||
| - Follow the [KEDA installation guide](https://keda.sh/docs/2.14/deploy/) carefully, including any prerequisites specific to your Kubernetes setup. | |||
| - Follow the [KEDA installation guide](https://keda.sh/docs/deploy/) carefully, including any prerequisites specific to your Kubernetes setup. | |||
There was a problem hiding this comment.
nit: I think it might be even better to use relative path
Suggested change
| - Follow the [KEDA installation guide](https://keda.sh/docs/deploy/) carefully, including any prerequisites specific to your Kubernetes setup. | |
| - Follow the [KEDA installation guide](../deploy/) carefully, including any prerequisites specific to your Kubernetes setup. |
| @@ -24,7 +24,7 @@ description = "Procedure to Setup a Scaler in KEDA" | |||
|
|
|||
| KEDA supports various scalers that correspond to different event sources or triggers. Determining the right scaler is crucial for scaling your application based on the desired event source. | |||
|
|
|||
| 1. Visit the [KEDA Scalers documentation](https://keda.sh/docs/2.14/scalers/) and browse through the list of available scalers. | |||
| 1. Visit the [KEDA Scalers documentation](https://keda.sh/docs/scalers/) and browse through the list of available scalers. | |||
There was a problem hiding this comment.
Suggested change
| 1. Visit the [KEDA Scalers documentation](https://keda.sh/docs/scalers/) and browse through the list of available scalers. | |
| 1. Visit the [KEDA Scalers documentation](../scalers/) and browse through the list of available scalers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two links contained specific keda versions, one of them even not being the latest one.
I removed the version numbers, as the website redirects to the latest docs in this case.
Checklist