ScaledJob: Support metadata annotations for ephemeral volume claims #6259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpertin
force-pushed
the
6254-volumeclaim-metadata
branch
from
0a2a958 to
2e104a0
Compare
Signed-off-by: Dimitri Pertin <[email protected]>
dpertin
force-pushed
the
6254-volumeclaim-metadata
branch
from
2e104a0 to
ebb2775
Compare
|
Thanks for the fix! He have merged this PR, and I'd say that it will fix the current issue too. Could you double check it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
x-kubernetes-preserve-unknown-fieldsto ScaledJob CRD in order to support metadata in ephemeral volume claimsBased on #1311
Previously, ArgoCD used to see a diff, bypassed the error but kept the application "OutOfSync":
Yet a warning was triggered:
unknown field "spec.jobTargetRef.template.spec.volumes[5].ephemeral.volumeClaimTemplate.metadata.annotations"Now the change is applied, the desired block is part of the "live manifest" and the application is "Synced":
Checklist
Fixes #6254