Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor New Relic scaler #6326

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Refactor New Relic scaler #6326

merged 1 commit into from
Nov 11, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Nov 9, 2024 •
edited
Loading

  • Refactor the scaler to match the new metadata guidelines.
  • The New Relic test showed that "0" and "1" are also valid values ​​for a boolean, but TypedConfig only accepts "true" and "false". Therefore, in the setConfigValueHelper, the function of typed_config.go has been adjusted for boolean parsing.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner November 9, 2024 13:50
@rickbrouwer
Refactor New Relic scaler
c4e39d8 
Signed-off-by: rickbrouwer <[email protected]>
@wozniakjan
Copy link
Member

wozniakjan commented Nov 11, 2024 •
edited by github-actions bot
Loading

/run-e2e newrelic
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan merged commit 211933e into kedacore:main Nov 11, 2024
20 checks passed
@wozniakjan wozniakjan mentioned this pull request Nov 11, 2024
Merged
1 task
@rickbrouwer rickbrouwer deleted the newrelic branch November 11, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickbrouwer @wozniakjan @JorTurFer