Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scaletargetref exists check in webhook and revise some variable name #6350

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ctccxxd
Copy link

@ctccxxd ctccxxd commented Nov 20, 2024

check scaletargetref exists in webhook and revise some variable name, originally,
1, There is not scaletargetref exists check code in webhook module.
2, Change the inappropriate variable name Gckr to Gvkr.
3, If still want to remain the function to create scaleobj first without real scaletargetRef obj. Think whether this function will be a way can be configged, to confirm the real scaletargetRef obj already exists when we create/update scaleobj. In this way, it can avoid the user misconfigurations about scaletargetRef in yaml file.

Checklist

Fixes #

Relates to #
#6354

@ctccxxd ctccxxd requested a review from a team as a code owner November 20, 2024 03:10
@ctccxxd ctccxxd changed the title check scaletargetref exists in webhook and revise some variable name add scaletargetref exists check in webhook and revise some variable name Nov 20, 2024
@SpiritZhou
Copy link
Contributor

Could you please open an issue for this improvement and relate this pr to the issue? This will make it clear and easy to tracing.

@ctccxxd
Copy link
Author

ctccxxd commented Nov 21, 2024

Could you please open an issue for this improvement and relate this pr to the issue? This will make it clear and easy to tracing.

done. Thank you.

@ctccxxd ctccxxd reopened this Nov 21, 2024
@ctccxxd
Copy link
Author

ctccxxd commented Nov 21, 2024

Friendly ping @zroubalik @wozniakjan @SpiritZhou @psi @wonko @fivesheep @JorTurFer hope you to review and discuss, much thanks.

@ctccxxd ctccxxd changed the title add scaletargetref exists check in webhook and revise some variable name feat: add scaletargetref exists check in webhook and revise some variable name Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants