-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize Dataset statistics in metadata panel #1472
Merged
Merged
Changes from 39 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
f86ac6f
initial draft with hooks
ravi-kumar-pilla 0370d56
modify test for formatFileSize
ravi-kumar-pilla e6e3898
add file size to the api response using fsspec
ravi-kumar-pilla 6812664
update unit test for metadata panel
ravi-kumar-pilla ccafa98
remove print statements and update stats file
ravi-kumar-pilla a37459c
update get file size to not consider empty dir
ravi-kumar-pilla 8c6965f
fixing linting and format errors
ravi-kumar-pilla 83bf822
Merge branch 'main' of https://github.com/kedro-org/kedro-viz into fe…
ravi-kumar-pilla 9466ea6
fix format and lint errors
ravi-kumar-pilla cf90243
fix pytest errors
ravi-kumar-pilla 5a08448
add test cases and add fix for circle ci builds
ravi-kumar-pilla bb5a342
resolve PR comments
ravi-kumar-pilla 9d66c92
fixing PR comments and add additional support for MemoryDataset
ravi-kumar-pilla 3103894
update stats and modify file_size extraction
ravi-kumar-pilla bbbeb7d
fix lint and format errors
ravi-kumar-pilla 72b8c74
fix lint errors
ravi-kumar-pilla 36760b4
fix lint errors
ravi-kumar-pilla dd65977
fix lint errors
ravi-kumar-pilla 86dd8ac
fix lint errors
ravi-kumar-pilla 37f7059
fix lint errors
ravi-kumar-pilla 3c231a0
Merge branch 'main' into feature/viz-size-datasets
tynandebold c3ff3e1
fix for PR comments
ravi-kumar-pilla 5b1f7e4
add test coverage for transcoded data node
ravi-kumar-pilla f7a4dc1
address PR comments
ravi-kumar-pilla d84f01f
fix lint errors
ravi-kumar-pilla 3b55684
modify test cases for hooks and utils
ravi-kumar-pilla 18d9974
add matplotlib in requirements file for e2e tests
ravi-kumar-pilla beb1e5e
Merge branch 'main' into feature/viz-size-datasets
ravi-kumar-pilla 4f3e77f
add design change for overflow
ravi-kumar-pilla b332dc2
Merge branch 'feature/viz-size-datasets' of https://github.com/kedro-…
ravi-kumar-pilla 8ddfffe
add design change for overflow
ravi-kumar-pilla cf21083
remove matplotlib from requirements and fix metadata suggestions
ravi-kumar-pilla 4213cf7
add release notes for visualizing dataset stats
ravi-kumar-pilla 57c139b
add release notes for displaying dataset stats
ravi-kumar-pilla f917c22
hooks update based on Nok's comments
ravi-kumar-pilla 7b88fc9
fix lint and format checks
ravi-kumar-pilla 2d823da
modify stats based on Nok's comments
ravi-kumar-pilla 381dfa4
fix lint and format
ravi-kumar-pilla 6dd02ff
fixed failing unit test
ravi-kumar-pilla ac65d0d
update code based on Nok's suggestion
ravi-kumar-pilla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"companies": { "rows": 77096, "columns": 5, "file_size": 1810602 }, | ||
"ingestion.int_typed_companies": { | ||
"rows": 77096, | ||
"columns": 5, | ||
"file_size": 550616 | ||
}, | ||
"reviews": { "rows": 77096, "columns": 10, "file_size": 2937144 }, | ||
"ingestion.int_typed_reviews": { | ||
"rows": 55790, | ||
"columns": 11, | ||
"file_size": 1335600 | ||
}, | ||
"shuttles": { "rows": 77096, "columns": 13, "file_size": 4195290 }, | ||
"ingestion.int_typed_shuttles": { | ||
"rows": 77096, | ||
"columns": 13, | ||
"file_size": 1235685 | ||
}, | ||
"ingestion.prm_agg_companies": { "rows": 50098, "columns": 5 }, | ||
"prm_shuttle_company_reviews": { | ||
"rows": 29768, | ||
"columns": 27, | ||
"file_size": 1020356 | ||
}, | ||
"prm_spine_table": { "rows": 29768, "columns": 3, "file_size": 655994 }, | ||
"feature_engineering.feat_derived_features": { "rows": 29768, "columns": 3 }, | ||
"feature_importance_output": { "rows": 15, "columns": 2, "file_size": 460 }, | ||
"feature_engineering.feat_static_features": { "rows": 29768, "columns": 12 }, | ||
"ingestion.prm_spine_table_clone": { "rows": 29768, "columns": 3 }, | ||
"reporting.cancellation_policy_breakdown": { | ||
"rows": 21, | ||
"columns": 3, | ||
"file_size": 8744 | ||
}, | ||
"model_input_table": { "rows": 29768, "columns": 12, "file_size": 787351 }, | ||
"X_train": { "rows": 23814, "columns": 11 }, | ||
"X_test": { "rows": 5954, "columns": 11 } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be
None
of{}
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be an empty dict. This method is called in the router.py where I was checking for None and initializing the stats to empty dict. Instead this way, we always get a dict for a data node