-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI due to lazy-loading #1481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Attempt to fix it in kedro-org/kedro-plugins#298 |
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
noklam
requested review from
tynandebold,
yetudada and
rashidakanchwala
as code owners
August 14, 2023 16:09
tynandebold
requested review from
deepyaman and
ravi-kumar-pilla
and removed request for
yetudada
August 14, 2023 16:12
tynandebold
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. All checks are passing. Thanks so much.
ravi-kumar-pilla
approved these changes
Aug 14, 2023
Co-authored-by: Tynan DeBold <[email protected]>
@tynandebold @ravi-kumar-pilla The test start failing after I merge from main, would you have a look at this? Feel free to merge it whenever it passed. |
1 task
noklam
changed the title
Attempt to fix CI due to lazy-loading
Fix CI due to lazy-loading
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kedro-viz/package/kedro_viz/integrations/kedro/data_loader.py
Lines 15 to 32 in 6e1d127
This is no longer valid because
kedro-datasets
is lazily load and ImportError is not produce immediately.The original code is slightly confusing, because
ImportError
can happens in 2 situationskedro-datasets
is not installed (This is what the original code intend to catch and have nothing to do with whether dependencies (i.e.pandas
,matplotlib
) is installed or not.This is the comments in the code base
This is no longer True. Previously, if the dependencies is not installed,
MatplotlibWriter
won't be available due to the suppression ofImportError
.Development notes
ImportError
for lazy-evaluation (kedro_datasets), catchAttributeError
for eager evaluation (kedro.extras)QA notes
Checklist
RELEASE.md
file