Remove Python Upper Bound Requirements #1506

ravi-kumar-pilla · 2023-08-25T23:06:29Z

Description

Resolves #1505

Development notes

kedro-org/kedro#2742

QA notes

Navigate to kedro-viz project folder 
Checkout branch - chore/remove-upper-bound

Local conda env setup for python 3.11 -

Create a conda environment with python 3.11 -
```
conda create -n yourenvname python=3.11
```
Activate the created conda environment -
```
conda activate yourenvname
```

Testing kedro-viz dev server -

Install package dependencies for kedro-viz -

pip3 install -r package/test_requirements.txt -r demo-project/src/docker_requirements.txt

Run backend server by executing the command -
```
make run
```

You should observe a warning as below -

Org/kedro-viz/package/kedro_viz/__init__.py:16: KedroVizPythonVersionWarning: Please be                     
                         advised that Kedro Viz is not yet fully                                                                     
                                 compatible with the Python version you are currently using.                                         
                           warnings.warn(

Testing kedro-viz as a package -

Build frontend
```
 make build    
```
Install local Kedro-viz package - 
```
pip install -e package
```
Navigate to demo-project -  
```
cd demo-project
```
Execute kedro viz command to open up in the browser here
```
 kedro viz
```

You should observe a warning as below -

Org/kedro-viz/package/kedro_viz/__init__.py:16: KedroVizPythonVersionWarning: Please be                     
                         advised that Kedro Viz is not yet fully                                                                     
                                 compatible with the Python version you are currently using.                                         
                           warnings.warn(

Checklist

Read the contributing guidelines
Opened this PR as a 'Draft Pull Request' if it is work-in-progress
Updated the documentation to reflect the code changes
Added new entries to the RELEASE.md file
Added tests to cover my changes

…ature/support-python_3.11

…o-org/kedro-viz into feature/support-python_3.11

package/kedro_viz/__init__.py

astrojuanlu

🔥

rashidakanchwala

LGTM ! thanks Ravi!

* initial draft for python 3.11 support * update release doc * add python warnings for e2e tests * modify e2e test * modify e2e test * test by removing lower req scenario * skip e2e tests for lower bound requirement on python 3.11 * skip e2e tests for lower bound requirement on python 3.11 * remove python upperbounds initial draft * fix lint and format errors * test remove upperbound warning * test lowerbound pandas install * revert back pandas requirement * bump lower requirements for pandas * remove upper bound clean up * update release notes * fix PR comments --------- Co-authored-by: Nok Lam Chan <[email protected]> Signed-off-by: ravi-kumar-pilla <[email protected]>

* initial draft for resolving connection error * refactor launchers and test code * modify unit tests * fix lint errors * fix run_viz tests * update unit test for coverage * update unit tests * Refactor visualize dataset stats from DataNodeMetadata to DataNode (#1499) * add stats to data node * lint and format check fix * fix pytests * fix layout issue * fix transcoded data stats Signed-off-by: ravi-kumar-pilla <[email protected]> * initial draft for resolving connection error Signed-off-by: ravi-kumar-pilla <[email protected]> * Support for Python 3.11 (#1502) * initial draft for python 3.11 support * update release doc * add python warnings for e2e tests * modify e2e test * modify e2e test * test by removing lower req scenario * skip e2e tests for lower bound requirement on python 3.11 * skip e2e tests for lower bound requirement on python 3.11 * remove print statements --------- Co-authored-by: Nok Lam Chan <[email protected]> Signed-off-by: ravi-kumar-pilla <[email protected]> * Remove Python Upper Bound Requirements (#1506) * initial draft for python 3.11 support * update release doc * add python warnings for e2e tests * modify e2e test * modify e2e test * test by removing lower req scenario * skip e2e tests for lower bound requirement on python 3.11 * skip e2e tests for lower bound requirement on python 3.11 * remove python upperbounds initial draft * fix lint and format errors * test remove upperbound warning * test lowerbound pandas install * revert back pandas requirement * bump lower requirements for pandas * remove upper bound clean up * update release notes * fix PR comments --------- Co-authored-by: Nok Lam Chan <[email protected]> Signed-off-by: ravi-kumar-pilla <[email protected]> * refactor launchers and test code Signed-off-by: ravi-kumar-pilla <[email protected]> * modify unit tests Signed-off-by: ravi-kumar-pilla <[email protected]> * fix lint errors Signed-off-by: ravi-kumar-pilla <[email protected]> * Fix: Adding favicon to Kedro Demo (#1509) * Fix: Adding favicon to Kedro Demo * Fix: Change in approach for serving favicon * Lint error fix * Lint error fix * Favicon endpoint test added * Favicon endpoint test added * Lint error fixed * Fix: Adding favicon to Kedro Demo Signed-off-by: Jitendra Gundaniya <[email protected]> * Fix: Change in approach for serving favicon Signed-off-by: Jitendra Gundaniya <[email protected]> * Lint error fix Signed-off-by: Jitendra Gundaniya <[email protected]> * Lint error fix Signed-off-by: Jitendra Gundaniya <[email protected]> * Favicon endpoint test added Signed-off-by: Jitendra Gundaniya <[email protected]> * Favicon endpoint test added Signed-off-by: Jitendra Gundaniya <[email protected]> * Lint error fixed Signed-off-by: Jitendra Gundaniya <[email protected]> * Fixed favicon endpoint test * Release doc updated * Update RELEASE.md Co-authored-by: rashidakanchwala <[email protected]> * Removed pytest.fixture as per review comment --------- Signed-off-by: Jitendra Gundaniya <[email protected]> Co-authored-by: rashidakanchwala <[email protected]> Signed-off-by: ravi-kumar-pilla <[email protected]> * fix run_viz tests Signed-off-by: ravi-kumar-pilla <[email protected]> * update unit test for coverage Signed-off-by: ravi-kumar-pilla <[email protected]> * Release v6.5.0 (#1513) * v6.5.0 * release * update-reminder-content * update reminder Signed-off-by: ravi-kumar-pilla <[email protected]> * remove branch condition for automate release version check (#1514) Signed-off-by: ravi-kumar-pilla <[email protected]> * update unit tests Signed-off-by: ravi-kumar-pilla <[email protected]> * add release record * modify comment * fix PR comments * DCO fix * fixing dco Signed-off-by: ravi-kumar-pilla <[email protected]> * update pytest Signed-off-by: ravi-kumar-pilla <[email protected]> --------- Signed-off-by: ravi-kumar-pilla <[email protected]> Signed-off-by: Jitendra Gundaniya <[email protected]> Co-authored-by: Rashida Kanchwala <[email protected]> Co-authored-by: Nok Lam Chan <[email protected]> Co-authored-by: Jitendra Gundaniya <[email protected]> Co-authored-by: rashidakanchwala <[email protected]>

ravi-kumar-pilla and others added 20 commits August 22, 2023 16:48

initial draft for python 3.11 support

a1929b1

Merge branch 'main' into feature/support-python_3.11

f9ef71d

Merge branch 'main' of https://github.com/kedro-org/kedro-viz into fe…

b635d21

…ature/support-python_3.11

update release doc

ac4e74c

Merge branch 'feature/support-python_3.11' of https://github.com/kedr…

3846943

…o-org/kedro-viz into feature/support-python_3.11

add python warnings for e2e tests

4d8c3b7

Merge branch 'main' into feature/support-python_3.11

12aa54d

modify e2e test

0c22e1b

Merge branch 'feature/support-python_3.11' of https://github.com/kedr…

8c46939

…o-org/kedro-viz into feature/support-python_3.11

modify e2e test

39c206e

test by removing lower req scenario

bda1597

skip e2e tests for lower bound requirement on python 3.11

a12e28c

skip e2e tests for lower bound requirement on python 3.11

725f0d5

remove python upperbounds initial draft

f32c71e

fix lint and format errors

a00931b

test remove upperbound warning

1875998

test lowerbound pandas install

f5eb44b

revert back pandas requirement

6318305

bump lower requirements for pandas

58748f9

remove upper bound clean up

fdafa72

ravi-kumar-pilla marked this pull request as ready for review August 28, 2023 19:35

ravi-kumar-pilla requested review from tynandebold, yetudada and rashidakanchwala as code owners August 28, 2023 19:35

update release notes

d39b10b

ravi-kumar-pilla requested review from astrojuanlu, jitu5, NeroOkwa and vladimir-mck August 28, 2023 19:42

astrojuanlu reviewed Aug 29, 2023

View reviewed changes

package/kedro_viz/__init__.py Outdated Show resolved Hide resolved

ravi-kumar-pilla mentioned this pull request Aug 29, 2023

Support for Python 3.11 #1502

Merged

5 tasks

fix PR comments

54d196d

astrojuanlu approved these changes Aug 29, 2023

View reviewed changes

NeroOkwa approved these changes Aug 29, 2023

View reviewed changes

resolve conflicts

35f11b8

rashidakanchwala approved these changes Aug 29, 2023

View reviewed changes

ravi-kumar-pilla merged commit 45705c1 into main Aug 30, 2023
1 check passed

ravi-kumar-pilla deleted the chore/remove-upper-bound branch August 30, 2023 03:39

rashidakanchwala mentioned this pull request Aug 31, 2023

Release v6.5.0 #1513

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Python Upper Bound Requirements #1506

Remove Python Upper Bound Requirements #1506

ravi-kumar-pilla commented Aug 25, 2023 •

edited

Loading

astrojuanlu left a comment

rashidakanchwala left a comment

Remove Python Upper Bound Requirements #1506

Remove Python Upper Bound Requirements #1506

Conversation

ravi-kumar-pilla commented Aug 25, 2023 • edited Loading

Description

Development notes

QA notes

Checklist

astrojuanlu left a comment

Choose a reason for hiding this comment

rashidakanchwala left a comment

Choose a reason for hiding this comment

ravi-kumar-pilla commented Aug 25, 2023 •

edited

Loading