-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Adding favicon to Kedro Demo #1509
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ba7f1b5
Fix: Adding favicon to Kedro Demo
jitu5 cd8aa6c
Fix: Change in approach for serving favicon
jitu5 1e24f5d
Lint error fix
jitu5 af086af
Lint error fix
jitu5 a586149
Favicon endpoint test added
jitu5 e8b9ba1
Favicon endpoint test added
jitu5 2ad9a60
Lint error fixed
jitu5 50d0d2f
Fix: Adding favicon to Kedro Demo
jitu5 2778c0f
Fix: Change in approach for serving favicon
jitu5 8241600
Lint error fix
jitu5 b318427
Lint error fix
jitu5 82508d4
Favicon endpoint test added
jitu5 cefb8f4
Favicon endpoint test added
jitu5 02dc49d
Lint error fixed
jitu5 a48ab54
Fixed favicon endpoint test
jitu5 f83cb85
Merge branch 'fix/favicon_in_demo' of https://github.com/kedro-org/ke…
jitu5 d620df3
Release doc updated
jitu5 3143185
Merge branch 'main' into fix/favicon_in_demo
jitu5 a4bac94
Update RELEASE.md
jitu5 d960122
Removed pytest.fixture as per review comment
jitu5 ad3c47b
Merge branch 'fix/favicon_in_demo' of https://github.com/kedro-org/ke…
jitu5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ - we have 2 content-types here, is it because of linux and windows tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here 'image/x-icon' is commonly used MIME type for ICO files, some server configurations might use 'image/vnd.microsoft.icon' as ICO files content type, in fact our test setup uses 'image/vnd.microsoft.icon' as ICO files content type. So added both content type for checks.