Fix Kedro logging broadcasting markup log message to all handlers. #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok Lam Chan <[email protected]>
noklam
commented
Feb 18, 2025
Comment on lines
210
to
215
| # Emit some logs | ||
| assert not custom_handler.records | ||
| catalog.save("dummy", data) | ||
| assert custom_handler.records | ||
| for record in custom_handler.records: | ||
| assert "[dark_orange]" not in record.message |
There was a problem hiding this comment.
This should sufficiently show that even with a dummy handler, it still capture the rich markup.
@astrojuanlu
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
noklam
commented
Feb 18, 2025
| @@ -54,3 +57,20 @@ def __init__(self, *args: Any, **kwargs: Any): | |||
| # fixed on their side at some point, but until then we disable it. | |||
| # See https://github.com/Textualize/rich/issues/2455 | |||
| rich.traceback.install(**traceback_install_kwargs) # type: ignore[arg-type] | |||
|
|
|||
| def emit(self, record: LogRecord): | |||
There was a problem hiding this comment.
The trick here is to keep the raw message without markup language. The handler will be responsible to add the [brackets] (I believe this is how rich.RichHandler functions anyway)
Signed-off-by: Nok Lam Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Development notes
Kedro.logging.RichHandler.LogRecordand raw message without markup.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile