Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a consistent file name in testing docs #4513

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

lvvittor
Copy link
Contributor

@lvvittor lvvittor commented Feb 21, 2025

Description

Normalize the testing file name in the documentation and remove extra indentation in Python code blocks.

Development notes

The documentation for adding test is not well written, for this PR I normalize the file names and remove extra indentation in the examples.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@lvvittor lvvittor changed the title chore(docs): set a consistent file name Set a consistent file name in testing docs Feb 21, 2025
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lvvittor! 🙌🏼

@lvvittor
Copy link
Contributor Author

@yetudada could you approve this PR so I can write the release file and merge the PR?

@imMatheus
Copy link

Wow, this is the best PR ever man! I just got some issues with this, thanks for fixing @lvvittor!

@astrojuanlu
Copy link
Member

Requested another review from the team 🙏🏼

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lvvittor 💯

@astrojuanlu astrojuanlu enabled auto-merge (squash) February 25, 2025 12:45
@astrojuanlu astrojuanlu merged commit e975711 into kedro-org:main Feb 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants