Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate unit tests from integration tests #3592

Open
nkuba opened this issue May 30, 2023 · 0 comments
Open

Separate unit tests from integration tests #3592

nkuba opened this issue May 30, 2023 · 0 comments
Labels
📟 client

Comments

@nkuba
Copy link
Member

nkuba commented May 30, 2023

In #3589 we added integration tests to be executed in CI. Unfortunately, due to how Go build tags work running the integration tests will include unit tests, which is unnecessary duplication. We should add //go:build !integration to all the unit tests to separate them (see: https://mickey.dev/posts/go-build-tags-testing/).
@nkuba nkuba mentioned this issue May 30, 2023
Merged
michalinacienciala added a commit that referenced this issue May 31, 2023
@michalinacienciala
Run Keep Client integration tests in CI (#3589)
bfb505f 
We add Keep Client's integration tests execution to the CI process. The
tests will be executed after the client build and unit tests pass.

Please note that with the current configuration, the integration tests
running command will execute also unit tests. To change this behavior we
will need to add `//go:build !integration` to all the non-integration
test files. (see: #3592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📟 client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkuba