Run Keep Client integration tests in CI #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add Keep Client's integration tests execution to the CI process. The tests will be executed after client build and unit tests pass.
We don't want to build the same image twice, we want to share it between the jobs. This is a solution where the image is saved in the disk storage and passed to another job. This solution is based on docker/build-push-action#225 (comment)
Since build-push-action doesn't support outputing an image to multiple outputs we need to save it in a separate step. See: moby/buildkit#1555 Once multiple outputs are supported we can replace this step with `outputs` property configured in `Build Docker Build Image`: outputs: | type=image type=docker,dest=/tmp/go-build-env-image.tar
It expects a path to a directory not the destination file.
We should use v3 for consistency with other actions.
The server is now is running with bitcoind deamon instead of bcoin, which made the error message change.
michalinacienciala
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add Keep Client's integration tests execution to the CI process. The tests will be executed after the client build and unit tests pass.
Please note that with the current configuration, the integration tests running command will execute also unit tests. To change this behavior we will need to add
//go:build !integrationto all the non-integration test files. (see: #3592)Refs: #3594