Moving funds commitment implementation #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-zimnoch
requested changes
Dec 1, 2023
tomaszslabon
force-pushed
the
moving-funds-commitment
branch
from
e467cc2 to
6ff4af7
Compare
tomaszslabon
force-pushed
the
moving-funds-commitment
branch
from
80e34b6 to
590e84d
Compare
tomaszslabon
force-pushed
the
moving-funds-commitment
branch
from
8f67d89 to
875f5f5
Compare
tomaszslabon
force-pushed
the
moving-funds-commitment
branch
from
3244708 to
62e8f0a
Compare
tomaszslabon
force-pushed
the
moving-funds-commitment
branch
from
62e8f0a to
d2b5cc0
Compare
tomaszslabon
force-pushed
the
moving-funds-commitment
branch
from
a1f5e64 to
4672795
Compare
lukasz-zimnoch
approved these changes
Feb 8, 2024
| // Search for the operator address in the cache. Store the operator | ||
| // address in the cache if it's not there. | ||
| if operatorID, found := operatorIDCache[operatorAddress]; !found { | ||
| operatorID, err := mft.chain.GetOperatorID(operatorAddress) |
There was a problem hiding this comment.
Non-blocking and we can address this in the next PR: Let's rename this operatorID to fetchedOperatorID to not shadow the variable declared in the if.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Refs: #3733.
This PR introduces functionalities that enable a wallet to submit a moving funds commitment. These functionalities have been incorporated into the
tbtcpgpackage through the creation and execution of aMovingFundsTask.They were implemented in the same manner as other procedures such as deposit sweeps and redemptions.
The task results in a moving funds proposal, which is needed for generating the Bitcoin transaction that transfer funds between wallets. Usually, this process will also involve submitting the moving funds commitment transaction to the
Bridge. This submission step may be skipped if the commitment has already been submitted, which can occur if a previously initiated moving funds procedure was interrupted post-commitment submission and still needs completion.Executing a moving funds task consists of several key steps:
Upon completion of the moving funds task, all necessary prerequisites for the Bitcoin moving funds transaction should be satisfied.