Tweak logs around network #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libp2p pubsub implementation produces a huge amount of duplicated `info` logs if one of the participants goes offline during messaging. This increases costs of logs storage and makes debugging harder. To overcome that problem, we are setting pubsub logs to the `warn` level by default and provide a way to customize this setting through the `PUBSUB_LOG_LEVEL` env variable. We will also add some app-level logging that will help detecting offline members.
This information is often relevant during DKG debugging. It is good to have it visible out of the box
This test aims to diagnose potential problems with nodes that can initiate connections on their own but cannot be reached from the public internet.
tomaszslabon
approved these changes
Feb 9, 2024
lukasz-zimnoch
added a commit
that referenced
this pull request
Feb 12, 2024
This pull request backports #3777 to the `releases/mainnet/v2.0.0-m7` branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3770
Here we are tweaking some logs, mostly related to the network layer. The goal here is to make debugging easier. We are trying to achieve that by adding additional logs that may help during that process and limiting the unuseful ones. I recommend reviewing commit by commit. A short summary of changes:
warnby default and make that customizable using thePUBSUB_LOG_LEVELenvironment variable (b725e1c)