[Backport] Single-shot DKG #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently used DKG retry mechanism based on random exclusion turned out to be ineffective for a higher number of participating operators. Such retries have a very small chance for success and produce a lot of unnecessary network traffic that consumes bandwidth and CPU excessively. Here we aim to improve the situation. First, we are making DKG a single-shot process which fails fast if the result cannot be produced during the first attempt. Second, we are doubling down the announcement period to maximize participation chance for all selected operators, even those being at the edge of the network. Last but not least, we are reducing the submission delay that is preserved between operators attempting to submit the final result on-chain. All those changes combined allow to achieve shorter DKG iterations that can be timed out quicker. This way, we will be able to repeat DKG more often, with different operator sets. (cherry picked from commit 7896c7a)
All DKG states use the `BackoffRetransmissionStrategy` strategy. There is no point to make an exception for the `resultSigningState`. This should reduce network load in case one of the participants fails at the end of the protocol. (cherry picked from commit 5049f77)
lukasz-zimnoch
requested review from
pdyraga,
nkuba,
dimpar and
tomaszslabon
as code owners
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/7869853939 check. |
tomaszslabon
approved these changes
Feb 12, 2024
lukasz-zimnoch
merged commit cbf53d5
into
releases/mainnet/v2.0.0-m7
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request backports #3776 to the
releases/mainnet/v2.0.0-m7branch.