Additional check when ensuring wallet synchronised between chains #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
changed the title
lukasz-zimnoch
previously approved these changes
Mar 15, 2024
lukasz-zimnoch
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Depends on #3793.
This PR adds an additional check when ensuring the wallet is synchronised between chain.
The new check involves verifying if any UTXO assigned to the wallet comes from the moved funds sweep transaction.
We only checked if the UTXO comes from a deposit sweep transaction, but it is also possible a moved funds sweep could be the first transaction coming from a new wallet.
Additionally, the
GetMovedFundsSweepRequestfunction was updated to follow the same pattern as functions for getting deposit sweep requests or pending redemption requests.