Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heartbeats: Changes to the inactivity claim trigger #3816

Merged
merged 1 commit into from
May 20, 2024
Merged

Heartbeats: Changes to the inactivity claim trigger #3816

merged 1 commit into from
May 20, 2024
+149 −71

Conversation

lukasz-zimnoch
Copy link
Member

Refs: #3796

Here we introduce the following changes to the heartbeat inactivity claim trigger:

  • So far, inactivity claims have been issued with an empty inactive members set. This is a problem as the on-chain contract expects it to be non-zero. We comply with this requirement here.
  • Heartbeat signing errors are no longer counted as consecutive heartbeat inactivity failures. If signing fails, the most probable cause is the signing threshold that was not met. As an inactivity claim requires that threshold to be met as well, there is no sense in triggering that process in this case. Moreover, in case of a signing error, the inactive members set cannot be determined which violates the requirement from the first point

@lukasz-zimnoch
Changes in the inactivity claim trigger
61376d2 
Here we introduce the following changes:
- Inactivity claims are always issued with a non-empty inactive members
  set. This is a hard on-chain requirement that was missed so far
- Heartbeat signing errors are not counted as consecutive heartbeat
  inactivity failure. This is because if signing failed, the inactivity
  claim will likely fail as well. Moreover, in case of signing error
  the inactive members set cannot be determined which violates the requirement
  from the first point
@lukasz-zimnoch lukasz-zimnoch self-assigned this May 20, 2024
@lukasz-zimnoch lukasz-zimnoch mentioned this pull request May 20, 2024
Closed
@tomaszslabon tomaszslabon enabled auto-merge May 20, 2024 12:22
@tomaszslabon tomaszslabon merged commit 27a8b97 into main May 20, 2024
29 checks passed
@tomaszslabon tomaszslabon deleted the tweaks-inactivity-claim branch May 20, 2024 12:33
@lukasz-zimnoch lukasz-zimnoch added this to the v2.1.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszslabon tomaszslabon tomaszslabon approved these changes

Assignees

@lukasz-zimnoch lukasz-zimnoch

Labels
📟 client
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasz-zimnoch @tomaszslabon