Dashboard integration bugs #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed error while declaring EthereumWalletRegistry instance. Error caused using Mainnet contracts on Goerli chain resulting with error when SDK is consumed with an entrypoint.
kpyszkowski
force-pushed
the
fix/dashboard-integration-bugs
branch
from
637570e to
aace2bc
Compare
The SDK uses a Node implementation of the URL API which is not complementary to the native browser implementation. I have added a conditional that if you have window.URL available then use it, and if you don't have it then fallback to the Node implementation
kpyszkowski
force-pushed
the
fix/dashboard-integration-bugs
branch
from
aace2bc to
a46b0f9
Compare
lukasz-zimnoch
previously approved these changes
Nov 1, 2023
lukasz-zimnoch
previously approved these changes
Nov 1, 2023
It's mandatory to check if `window` element is present in global scope before it's used.
kpyszkowski
force-pushed
the
fix/dashboard-integration-bugs
branch
from
3ad8f4d to
4c855ed
Compare
lukasz-zimnoch
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating
threshold-dashboardwith the latest iteration of the SDK, some bugs have been spotted. This pull request presents spotted issues, proposes and explains solutions. Each solution is explained in an additional commit message.