Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sepolia / Optimism Sepolia support for Optimism cross-chain #752

Merged
merged 13 commits into from
Feb 19, 2024

Conversation

michalinacienciala
Copy link
Contributor

@michalinacienciala michalinacienciala commented Nov 22, 2023

The Goerli testnet currently used by Threshold/Keep for development purposes was planned to become deprecated with the end of year 2023. Although it's already 2024, the testnet is still live, but it will loose validators over the time and may become unusable at some point. The testnet that was created to replace it is called
Holešky, however it will take some time until it gets integrated with by some of the projects we rely on. As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.

The Goerli -> Sepolia migration means that also L2 testnet based on Goerli (Optimism Goerli) needs to be migrated to Sepolia-based chain (Optimism Sepolia). In this PR we're adjusting the config used to deploy testnet contracts in the @keep-network/tbtc-v2-arbitrum project. After the update, both deploy to optimismGoerli and optimismSepolia networks will be supported (we may remove optimismGoerli support once we're sure the optimismSepolia deployment works as expected).

TODO

Ref: threshold-network/solidity-contracts#150

The Goerli testnet currently used by Threshold/Keep for development purposes is
planned to become deprecated with the end of year 2023. The testnet that was
created to replace it is called
[Holešky](https://github.com/eth-clients/holesky), however it will take some
time until it gets integrated with by some of the projects we rely on.
As a solution, we decided to switch first to another testnet that is currently
live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of
time to move to Holešky before Sepolia gets deprecated.
Until Görli is not dead we want to support both testnets.

The Goerli -> Sepolia migration means that also L2 testnet basing on Goerli
(Optimism Goerli) needs to be migrated to Sepolia-based chain (Optimism Sepolia).
At the moment Optimism Sepolia is not supported by Wormhole, so deployment of our
contracts on that testnet is yet not possible. But we're already adding changes
that prepare us for the moment when it will be supported.
Once support is confirmed, we'll need to verify if `wormholeChainID` we use in
the config is correct for the testnet.
@michalinacienciala michalinacienciala added the :shipit: deployment Deployments and CI workflows label Nov 22, 2023
The Optimism Sepolia testnet is not on the list of chains supported by the
`hardhat-verify` plugin
(https://github.com/NomicFoundation/hardhat/blob/main/packages/hardhat-verify/src/internal/chain-config.ts).
We're adding a custom configuration that will make the contracts verification
possible on that testnet (following the
https://hardhat.org/hardhat-runner/plugins/nomicfoundation-hardhat-verify#adding-support-for-other-networks
docs).
Wormhole has added support for Arbitrum Sepolia, Base Sepolia and Optimism
Sepolia testnets. We want to modify the config of our deployment scripts so that
deployment on Sepolia-based L2s would be possible. As the Chain IDs for Wormhole
Sepolia-based networks differ from from IDs for Mainnet and Goerli-based
testnets, we need to set the right value of `...WormholeChainID` constant for
the the right network we're deploying to.
@michalinacienciala michalinacienciala marked this pull request as ready for review January 18, 2024 16:58
Adding Sepolia-related contracts needed for deployment on `optimismSepolia`
network:
* `external/optimismSepolia/OptimismTokenBridge.json` - address taken from
  https://docs.wormhole.com/wormhole/blockchain-environments/evm#testnet-contracts-optimism-sepolia-11155420
* `external/optimismSepolia/SolanaWormholeGateway.json` - used the same value as in `optimismGoreli`
* `external/sepolia/TokenBridge.json` - address taken from
  https://docs.wormhole.com/wormhole/blockchain-environments/evm#testnet-contracts-sepolia-11155111

NOT included in this commit (but needed for the deployment):
* `external/optimismSepolia/OptimismWormholeTBTC.json` - in order to get the
  address we need to perform attestation of the Ethereum Sepolia TBTC token on
  Optimism Sepolia (but atm Optimism Sepolia is not available on the list of
  target networks on
  https://wormhole-foundation.github.io/example-token-bridge-ui/#/register)
Locally deployed portal was used to register TBTC.
We're adding artifacts for contracts deployed to Optimism Sepolia network.
We were using wrong condition for computation of wormholeChainID. As a result,
we've been associating Gateway Address with wrong chain. We've run the
`12_update_self_in_wormhole_gateway_mapping.ts` script once more and got new
deployment artifact.
Some dependencies were missing.
We were using wrong condition for computation of wormholeChainID. As a result,
we've been associating Gateway Address with wrong chains.
@michalinacienciala
Copy link
Contributor Author

We've deployed the contracts on Optimism Sepolia and published a package: @keep-network/[email protected]

We've registered gateways of other L2s in Wormhole Portal and tested bridging between the networks:

Optimism Sepolia -> Ethereum Sepolia:

Ethereum Sepolia -> Optimism Sepolia:

Sepolia Optimism > Sepolia Base

Sepolia Base > Sepolia Optimism

Sepolia Optimism > Sepolia Arbitrum

Sepolia Arbitrum > Sepolia Optimism

@lukasz-zimnoch lukasz-zimnoch merged commit 4c50eb3 into main Feb 19, 2024
38 checks passed
@lukasz-zimnoch lukasz-zimnoch deleted the sepolia-support-optimism branch February 19, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:shipit: deployment Deployments and CI workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants