SDK: Add coinbase data to the SPV proof builder #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABIs of some tBTC contracts changed recently. Here we bump up relevant contract packages to fetch those changes and adjust the SDK around.
This function allows to get the BTC coinbase transaction for the given block height.
tomaszslabon
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: GHSA-wg2x-rv86-mmpx
The SPV proof verifier used by the
Bridgecontract has been changed. It now expects the coinbase's preimage and merkle proof to be submitted as part of the proven transaction's SPV proof. Here we adhere to this requirement by adjusting the SDK's SPV proof builder accordingly.Note: Core changes presented in this PR are equivalent to keep-network/keep-core#3762