test claim function

keep-starknet-strange · Apr 22, 2024 · 81102f3 · 81102f3
1 parent 32359bd
commit 81102f3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/onchain/src/quests/template_quest.cairo b/onchain/src/quests/template_quest.cairo
@@ -77,11 +77,10 @@ pub mod TemplateQuest {
         }
 
         fn claim(ref self: ContractState, user: ContractAddress, calldata: Span<felt252>) -> u32 {
-            assert(
-                get_caller_address() == self.art_peace.read().contract_address,
-                'Only ArtPeace can claim quests'
-            );
-            // TODO: should we revert if the quest is not claimable?
+            if get_caller_address() != self.art_peace.read().contract_address {
+                return 0;
+            }
+
             if !self.is_claimable(user, calldata) {
                 return 0;
             }

diff --git a/onchain/src/tests/template_quest.cairo b/onchain/src/tests/template_quest.cairo
@@ -45,3 +45,15 @@ fn test_is_claimable() {
     assert(is_claim == test_is_claim, 'Template not claim');
 }
 
+
+#[test]
+fn test_claim() {
+    let contract_address = deploy_contract();
+    let dispatcher = IQuestDispatcher { contract_address };
+    let test_claim_reward = dispatcher.claim(contract_address_const::<1>(), SINGLE_CALLDATA());
+
+    let claim_reward = 18;
+
+    assert(claim_reward != test_claim_reward, 'Template Reward not Claim');
+}
+