Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Load Apibara Script Variables from Environment #25

Merged
merged 3 commits into from
Apr 16, 2024
Merged

[feat] Load Apibara Script Variables from Environment #25

merged 3 commits into from
Apr 16, 2024

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Apr 10, 2024

@TAdev0 TAdev0 requested a review from b-j-roberts as a code owner April 10, 2024 23:54
@TAdev0
Copy link
Contributor Author

TAdev0 commented Apr 10, 2024

@b-j-roberts here is a first draft. I'm not sure at all if what i did is what was expected

b-j-roberts
b-j-roberts requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also slightly new to Apibara, so it might take me a minute to review other parts and give a good explanation. But nice work so far.

indexer/docker-script.js Outdated Show resolved Hide resolved
indexer/docker-script.js Outdated Show resolved Hide resolved
@TAdev0 TAdev0 changed the title feat: Load Apibara Script Variables from Environment [feat] Load Apibara Script Variables from Environment Apr 11, 2024
@b-j-roberts b-j-roberts merged commit d21aa1c into keep-starknet-strange:main Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TAdev0 @b-j-roberts