Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas and more filters #267

Merged

Conversation

supreme2580
Copy link
Contributor

  • issue #
  • follows contribution guide
  • code change includes tests
  • breaking change

image

Copy link

vercel bot commented Nov 29, 2024

@supreme2580 is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left a couple requests, looks good otherwise.

backend/routes/canvas.go Outdated Show resolved Hide resolved
backend/routes/canvas.go Outdated Show resolved Hide resolved
@supreme2580
Copy link
Contributor Author

@b-j-roberts I have implemented core.ArtPeaceBackend.CanvasConfig.Round and set the default round number to 2 and use core.ArtPeaceBackend.CanvasConfig.Round as the default round number value

@b-j-roberts b-j-roberts merged commit 091610c into keep-starknet-strange:main Dec 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants