Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few improvements #33

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Apr 11, 2024

  • issue #
  • follows contribution guide
  • code change includes tests
  • breaking change

@b-j-roberts i will close my other PR , i had conflict issues i coudlnt solve easily and it was faster for me to do this way

@TAdev0 TAdev0 requested a review from b-j-roberts as a code owner April 11, 2024 20:08
@TAdev0
Copy link
Contributor Author

TAdev0 commented Apr 11, 2024

@b-j-roberts I also replaced alll assert! with assert() function in the codebase. While its nice in tests as you can easily print long strings, using the macro actually costs way more steps because of the ByteArray construct

@b-j-roberts
Copy link
Contributor

@b-j-roberts I also replaced alll assert! with assert() function in the codebase. While its nice in tests as you can easily print long strings, using the macro actually costs way more steps because of the ByteArray construct

Nice catch, had slipped my mind.

@b-j-roberts b-j-roberts merged commit 5c14814 into keep-starknet-strange:main Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants