add template quest contract and check is_claimable

[mubarak23]

• issue #29
• follows contribution guide
• code change includes tests
• breaking change

• create template quest contract that implement IQuest trait
• check the creator on templateMeta is equal to the user on is_claimable function

[b-j-roberts]

Nice work so far, left some further thoughts.

If you can make those changes, get it to build, and then create a test for it, that would be awesome!

[b-j-roberts]

It might be better to store this as a ContractAddress and have a separate storage slot for ITemplateStoreDispatcher since you won't be using the IArtPeaceDispatcher for anything.

[mubarak23]

you mean having art_peace: ContractAddress ?

[b-j-roberts]

Yes, that's right

[mubarak23]

if this contract is fine, i can proceed to start working on the test

[b-j-roberts]

There may be some bugs or things, but yeah, I'd say the idea is there. You can go ahead with the tests 👍

Thanks!

[mubarak23]

from my test, this line
self.art_peace.write( ITemplateStoreDispatcher { contract_address: init_params.art_peace });
returning error of "Type not found."

[mubarak23]

is_claimable function accept calldata of type Span<felt252>, if we pull out templateId let template_id = calldata[0]; it is going to be of type felt252 and our self.templates.get_template(template_id); expect a type of u32, there is a mismatch here, should i refactor our template to collect felt252 @b-j-roberts

[mubarak23]

should templates: LegacyMap::<u32, TemplateMetadata>, of TemplateStoreComponent Storage change to templates: LegacyMap::<felt252, TemplateMetadata>,

[mubarak23]

from my test, this line self.art_peace.write( ITemplateStoreDispatcher { contract_address: init_params.art_peace }); returning error of "Type not found."

i was able to solved this by using Declare component! syntax

[mubarak23]

from this context

let template_id_felt = calldata[0];

           let template_id: u32 = template_id_felt.try_into().unwrap();

           let template = self.templates.get_template(template_id);

template_id_felt is still throwing an error

Unexpected argument type. Expected: "core::integer::u32", found: "@core::felt252".

[b-j-roberts]

I'd prefer to keep template_id as u32. Try this let template_id_felt = *calldata.at(0); instead of calldata[0]

[mubarak23]

this let template_id_felt = *calldata.at(0); work

[mubarak23]

@b-j-roberts kindly review the test cases

[b-j-roberts]

Thank you for the work!

[mubarak23]

Really, i learn a lot from this issue, looking forward to contributing to the project