Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre commit hooks and setup #145

Merged
merged 2 commits into from
Aug 9, 2024
Merged

add pre commit hooks and setup #145

merged 2 commits into from
Aug 9, 2024

Conversation

feltroidprime
Copy link
Collaborator

@feltroidprime feltroidprime commented Aug 9, 2024

Adds pre commit file and install with https://pre-commit.com/ in the setup. Each time a commit is made locally it will check and fixes the files.
First time it might take 1 minute but following commits will be quick.

Added black formatting check in the actions to make sure it is working. Fixed same black version in the precommit hook and in requirements so that the precommit hook and the action are in sync.

@feltroidprime feltroidprime marked this pull request as ready for review August 9, 2024 10:51
@feltroidprime feltroidprime force-pushed the pre-commit-hooks branch 2 times, most recently from 0da2cb2 to 656d2c8 Compare August 9, 2024 10:59
@feltroidprime feltroidprime requested a review from raugfer August 9, 2024 11:12
Copy link
Collaborator

@raugfer raugfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@feltroidprime feltroidprime merged commit 2194b9b into main Aug 9, 2024
6 checks passed
@feltroidprime feltroidprime deleted the pre-commit-hooks branch August 12, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants