ZK_ecip Rust translattion

.gitignore

@@ -14,6 +14,13 @@ venv
 
 tools/garaga_rs/target/
 tools/garaga_rs/Cargo.lock
+<<<<<<< HEAD
+tools/garaga_rs/sys
+
+src/cairo/target/
+
+tools/garaga_rs/target/
+=======
 
 src/cairo/target/
 *target*

README.md

@@ -74,7 +74,10 @@ Ensure you have the following installed:
 - [pprof](https://github.com/google/pprof) - A tool for visualization and analysis of profiling data. Requires [Go](https://go.dev/).
 - [graphviz](https://graphviz.org/download/) - Necessary for generating graphical representations of profiling data.
 
+<<<<<<< HEAD
+=======
 
+>>>>>>> a504e556e4f9731d65815eff327cc8f5dd654411
 ### Setup
 
 Once you have the prerequisites installed, clone the repository, and set up your development environment with the following command. Be sure to run this command from the root of the repository.
@@ -96,6 +99,10 @@ At this point, you should have everything you need to start developing with Gara
 | ADDMOD           |                 4 | Equivalent cost of a+b % p with the modulo builtin in VM steps                          |
 | ASSERT_EQ        |                 2 | Equivalent cost of a==b % p with the modulo builtin in VM steps                         |
 | RLC              |                28 | Cost of writing a field element to the value segment and retrieving random coefficients |
+<<<<<<< HEAD
+| POSEIDON 3 LIMBS |                14 | Cost of hashing the first 3 limbs of 384 bits emulated field element with Poseidon      |
+=======
+>>>>>>> a504e556e4f9731d65815eff327cc8f5dd654411
 | POSEIDON 4 LIMBS |                17 | Cost of hashing the 4 limbs of 384 bits emulated field element with Poseidon            |
 
 

docs/hints_document.md

@@ -57,6 +57,16 @@ ids.elements_end - ids.elements >= ids.N_LIMBS
 ```
 
 - **[Lines 145-145](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//utils.cairo#L145-L145)**
+<<<<<<< HEAD
+
+```python
+ids.elements_end - ids.elements >= 6*ids.N_LIMBS
+```
+
+- **[Lines 147-152](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//utils.cairo#L147-L152)**
+
+```python
+=======
 
 ```python
 ids.elements_end - ids.elements >= 6*ids.N_LIMBS
@@ -85,7 +95,16 @@ ids.elements_end - ids.elements >= ids.N_LIMBS
 //     to_hash=pack_bigint_ptr(memory, ids.elements, ids.N_LIMBS, ids.BASE, 1)
 //     for e in to_hash:
 //         print(f"\t\t Will Hash {hex(e)}")
+<<<<<<< HEAD
+
+```
+
+- **[Lines 206-206](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//utils.cairo#L206-L206)**
+=======
+>>>>>>> a504e556e4f9731d65815eff327cc8f5dd654411
 
+```python
+print(f"res {hex(ids.res)}")
 ```
 
 - **[Lines 206-206](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//utils.cairo#L206-L206)**
@@ -527,11 +546,22 @@ print(f"\tRunning ModuloBuiltin circuit...")
 ```
 
 ## File: [src/fustat/precompiled_circuits/dummy.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/dummy.cairo)
+<<<<<<< HEAD
+
+## File: [src/fustat/precompiled_circuits/ec.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/ec.cairo)
+
+## File: [src/fustat/precompiled_circuits/extf_mul.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/extf_mul.cairo)
+
+## File: [src/fustat/precompiled_circuits/final_exp.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/final_exp.cairo)
+
+## File: [src/fustat/precompiled_circuits/multi_miller_loop.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/multi_miller_loop.cairo)
+=======
 
 ## File: [src/fustat/precompiled_circuits/ec.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/ec.cairo)
 
 ## File: [src/fustat/precompiled_circuits/extf_mul.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/extf_mul.cairo)
 
 ## File: [src/fustat/precompiled_circuits/final_exp.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/final_exp.cairo)
+>>>>>>> a504e556e4f9731d65815eff327cc8f5dd654411
 
 ## File: [src/fustat/precompiled_circuits/multi_miller_loop.cairo](https://github.com/keep-starknet-strange/garaga/blob/main/src/fustat//precompiled_circuits/multi_miller_loop.cairo)

hydra/garaga/algebra.py

@@ -1033,4 +1033,4 @@ def validate_degrees(self, msm_size: int) -> bool:
         return True
 
     def print_as_sage_poly(self, var: str = "x") -> str:
-        return f"(({self.b.numerator.print_as_sage_poly(var)}) / ({self.b.denominator.print_as_sage_poly(var)}) * y + ({self.a.numerator.print_as_sage_poly(var)} / ({self.a.denominator.print_as_sage_poly(var)})"
+        return f"(({self.b.numerator.print_as_sage_poly(var)}) / ({self.b.denominator.print_as_sage_poly(var)}) * y + ({self.a.numerator.print_as_sage_poly(var)} / ({self.a.denominator.print_as_sage_poly(var)})"

hydra/garaga/definitions.py

@@ -1107,4 +1107,4 @@ def replace_consecutive_zeros(lst):
 
 
 if __name__ == "__main__":
-    pass
+    pass

hydra/garaga/extension_field_modulo_circuit.py

@@ -841,4 +841,4 @@ def compile_circuit_cairo_zero(
 
 
 if __name__ == "__main__":
-    pass
+    pass

hydra/garaga/hints/bls.py

@@ -1,3 +1,9 @@
+<<<<<<< HEAD
+from hydra.hints.tower_backup import E12
+from hydra.definitions import CURVES, CurveID
+from math import gcd
+
+=======
 from math import gcd
 
 from garaga.definitions import CURVES, CurveID
@@ -21,6 +27,7 @@
 
 Since gcd(h1, λ) = 1 computing λ root of x_sh can be simply done by just raising x_sh^e where e = inverse_mod(h3, λ)
 """
+>>>>>>> a504e556e4f9731d65815eff327cc8f5dd654411
 
 # Bls
 
@@ -35,11 +42,14 @@
 
 p = 5044125407647214251
 h3 = h // (27 * p)
+<<<<<<< HEAD
+=======
 
 e = pow(lam, -1, h3)
 s = (-1 * pow(h3, -1, p * 27)) % (p * 27)
 
 
+>>>>>>> a504e556e4f9731d65815eff327cc8f5dd654411
 assert h % (27 * p) == 0
 assert m == 3 * p**2
 
@@ -55,6 +65,106 @@
 assert (q**3 - 1) % 27 == 0
 
 
+<<<<<<< HEAD
+def is_pth_residue(x: E12) -> bool:
+    return x ** (h3 * 27) == ONE
+
+
+def get_pth_root_inverse(x: E12) -> E12:
+    if is_pth_residue(x):
+        return ONE
+
+    v = 27 * h3
+    wj = x**v
+
+    v_inv = pow(v, -1, p)
+    s = (-1 * v_inv) % p
+
+    return wj**s
+
+
+def get_order_of_3rd_primitive_root(x: E12) -> int:
+    # correct way is do do r * p * h3 but outputs of equal Tate pairings are always of the form c^r thus there is no rth root contribution
+    y = x ** (p * h3)
+
+    if y == ONE:
+        return 0
+
+    y3 = y**3
+    if y3 == ONE:
+        return 1
+
+    y9 = y3**3
+    if y9 == ONE:
+        return 2
+
+    y27 = y9**3
+    if y27 == ONE:
+        return 3
+
+    else:
+        raise ValueError("")
+
+
+def get_any_27th_root_inverse(x: E12) -> E12:
+    pw = get_order_of_3rd_primitive_root(x)
+
+    if pw == 0:
+        return ONE
+
+    _ord = 3**pw
+
+    v = p * h3
+    wj = x**v
+
+    v_inv = pow(v, -1, _ord)
+    s = (-1 * v_inv) % _ord
+
+    return wj**s
+
+
+def h3_ord_element_lambda_root(x: E12) -> E12:
+    # after applying shifts we know that element is order just h3
+
+    e = pow(lam, -1, h3)
+    return x**e
+
+
+# assumes it's already of the form x^r
+def get_root_and_scaling_factor_bls(x: E12) -> tuple[E12, E12]:
+    assert x**h == ONE  # assert that x = f^r for some f
+    wp_shift = get_pth_root_inverse(x)
+    w27_shift = get_any_27th_root_inverse(x)
+
+    w_full = wp_shift * w27_shift
+    x_shifted = x * w_full
+    root = h3_ord_element_lambda_root(x_shifted)
+
+    return (root, w_full)
+
+
+if __name__ == "__main__":
+    from hydra.hints.multi_miller_witness import get_miller_loop_output
+
+    import random
+
+    random.seed(0)
+    for i in range(5):
+        f = get_miller_loop_output(curve_id=CurveID.BLS12_381, will_be_one=True)
+        root, w_full = get_root_and_scaling_factor_bls(f)
+        assert f * w_full == root**lam
+        print(f"{i} Will be one check ok")
+
+        f = get_miller_loop_output(curve_id=CurveID.BLS12_381, will_be_one=False)
+
+        try:
+            root, w_full = get_root_and_scaling_factor_bls(f)
+            assert f * w_full == root**lam
+        except (ValueError, AssertionError):
+            print(f"{i} No nth root -- Ok")
+        else:
+            raise ValueError("Non-one case should not pass")
+=======
 def get_root_and_scaling_factor_bls(mlo: E12) -> tuple[E12, E12]:
     """
     Takes a miller loop output and returns root, shift such that
@@ -64,3 +174,4 @@ def get_root_and_scaling_factor_bls(mlo: E12) -> tuple[E12, E12]:
     shift = x**s
     root = (shift * mlo) ** e
     return root, shift
+>>>>>>> a504e556e4f9731d65815eff327cc8f5dd654411

hydra/garaga/hints/ecip.py

@@ -4,6 +4,8 @@
 import functools
 from dataclasses import dataclass
 
+import garaga_rs
+
 from garaga.algebra import Fp2, FunctionFelt, Polynomial, PyFelt, RationalFunction, T
 from garaga.definitions import CURVES, CurveID, G1Point, G2Point, get_base_field
 from garaga.hints.neg_3 import (
@@ -102,12 +104,33 @@ def zk_ecip_hint(
     """
     assert len(Bs) == len(scalars)
 
-    dss = construct_digit_vectors(scalars)
-    Q, Ds = ecip_functions(Bs, dss)
-    dlogs = [dlog(D) for D in Ds]
-    sum_dlog = dlogs[0]
-    for i in range(1, len(dlogs)):
-        sum_dlog = sum_dlog + (-3) ** i * dlogs[i]
+    ec_group_class = get_ec_group_class_from_ec_point(Bs[0])
+    if ec_group_class == G1Point:
+        pts = []
+        c_id = Bs[0].curve_id
+        for pt in Bs:
+            pts.extend([pt.x, pt.y])
+        field_type = get_field_type_from_ec_point(Bs[0])
+        field = get_base_field(c_id.value, field_type)
+
+        q, a_num, a_den, b_num, b_den = garaga_rs.zk_ecip_hint(pts, scalars, c_id.value)
+        a_num = [field(int(f, 16)) for f in a_num]
+        a_den = [field(int(f, 16)) for f in a_den]
+        b_num = [field(int(f, 16)) for f in b_num]
+        b_den = [field(int(f, 16)) for f in b_den]
+
+        Q = G1Point(q[0], q[1], c_id)
+        sum_dlog = FunctionFelt(
+            RationalFunction(Polynomial(a_num), Polynomial(a_den)),
+            RationalFunction(Polynomial(b_num), Polynomial(b_den)),
+        )
+    else:
+        dss = construct_digit_vectors(scalars)
+        Q, Ds = ecip_functions(Bs, dss)
+        dlogs = [dlog(D) for D in Ds]
+        sum_dlog = dlogs[0]
+        for i in range(1, len(dlogs)):
+            sum_dlog = sum_dlog + (-3) ** i * dlogs[i]
     return Q, sum_dlog
 
 

hydra/garaga/hints/extf_mul.py

@@ -7,6 +7,7 @@
     get_base_field,
     get_irreducible_poly,
     tower_to_direct,
+    get_base_field,
 )
 from garaga.hints.tower_backup import E6, get_tower_object
 
@@ -78,14 +79,24 @@ def nondeterministic_extension_field_div(
 
 
 if __name__ == "__main__":
+<<<<<<< HEAD
+    from hydra.definitions import (
+        BN254_ID,
+        BLS12_381_ID,
+        get_base_field,
+        CURVES,
+=======
     from random import randint as rint
 
     from garaga.definitions import (
         BLS12_381_ID,
         BN254_ID,
         get_base_field,
+>>>>>>> a504e556e4f9731d65815eff327cc8f5dd654411
         get_irreducible_poly,
     )
+    from random import randint as rint
+    import random
 
     field = get_base_field(BN254_ID)
     p = field.p

hydra/garaga/hints/frobenius.py

@@ -222,4 +222,4 @@ def test_frobenius_maps():
         CURVES[1].p,
         1,
         get_irreducible_poly(1, 12),
-    )
+    )

hydra/garaga/hints/io.py

@@ -264,4 +264,4 @@ def _getattr(obj, attr):
 
 def rsetattr(obj, attr, val):
     pre, _, post = attr.rpartition(".")
-    return setattr(rgetattr(obj, pre) if pre else obj, post, val)
+    return setattr(rgetattr(obj, pre) if pre else obj, post, val)

hydra/garaga/hints/multi_miller_witness.py

@@ -234,4 +234,4 @@ def test_bn254():
 
     for i in range(10):
         test_bn254()
-        print(f"Test {i} passed")
+        print(f"Test {i} passed")

hydra/garaga/hints/neg_3.py

@@ -65,4 +65,4 @@ def sign(felt252: int) -> int:
 
 
 if __name__ == "__main__":
-    print(positive_negative_multiplicities(neg_3_base_le(2**128)))
+    print(positive_negative_multiplicities(neg_3_base_le(2**128)))

hydra/garaga/hints/tower_backup.py

@@ -478,4 +478,4 @@ def get_tower_object(x: list[PyFelt], curve_id: int, extension_degree: int):
     elif extension_degree == 12:
         return E12(x, curve_id)
     else:
-        raise ValueError
+        raise ValueError

hydra/garaga/modulo_circuit.py

@@ -1135,4 +1135,4 @@ def summarize(self):
     print(d)
 
     circuit = ModuloCircuit("test_empty_circuit", curve_id=0, compilation_mode=1)
-    print(circuit.compile_circuit())
+    print(circuit.compile_circuit())

hydra/garaga/modulo_circuit_structs.py

@@ -926,4 +926,4 @@ def __len__(self) -> int:
             assert len(self.elmts) == 6
             return 6
         else:
-            return 6
+            return 6

hydra/garaga/poseidon_transcript.py

@@ -166,4 +166,4 @@ def gen_cairo_test_vectors(n_elmts: int):
 
     print(gen_cairo_test_vectors(1))
     print(gen_cairo_test_vectors(2))
-    print(gen_cairo_test_vectors(3))
+    print(gen_cairo_test_vectors(3))