Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error handling and parsing in parsing_utils.py #233

Merged
merged 18 commits into from
Oct 18, 2024
Merged

Improved error handling and parsing in parsing_utils.py #233

merged 18 commits into from
Oct 18, 2024

Conversation

stefanMadzharov
Copy link
Contributor

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

Issue Number: 230

Does this introduce a breaking change?

  • Yes
  • No

@stefanMadzharov stefanMadzharov changed the title Improved error handling in parsing_utils.py Improved error handling and parsing in parsing_utils.py Oct 17, 2024
feltroidprime
feltroidprime requested changes Oct 18, 2024
View reviewed changes
hydra/garaga/starknet/groth16_contract_generator/parsing_utils.py Outdated
Comment on lines 21 to 25
RISC0_CONTROL_ROOT = 0xA516A057C9FBF5629106300934D48E0E775D4230E41E503347CAD96FCBDE7E2E
RISC0_BN254_CONTROL_ID = (
0x05A022E1DB38457FB510BC347B30EB8F8CF3EDA95587653D0EAC19E1F10D164E
0x0EB6FEBCF06C5DF079111BE116F79BD8C7E85DC9448776EF9A59AAF2624AB551
)

Copy link
Collaborator

@feltroidprime feltroidprime Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't change, they were already the latest values
https://github.com/risc0/risc0-ethereum/blob/main/contracts/src/groth16/ControlID.sol 🤔
What happened ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was debugging my program and didn't see that this it was included in the commit.

Copy link
Contributor Author

@stefanMadzharov stefanMadzharov Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I am not sure they are the latest values. The latest values should be those here. You can check Issue#234. I have explained my train of thoughts there.

@feltroidprime
Copy link
Collaborator

Lgtm

@feltroidprime feltroidprime merged commit 1018d21 into keep-starknet-strange:main Oct 18, 2024
27 checks passed
@feltroidprime feltroidprime mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feltroidprime feltroidprime feltroidprime requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanMadzharov @feltroidprime @StefanMadzh