Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos for groth16.cairo and pairing_check.cairo #277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some typos for groth16.cairo and pairing_check.cairo #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/src/groth16.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
/// The result of e(Pf4, Qf4) is precomputed and provided to the circuit as a the miller loop result
/// precomputed_miller_loop_result = MillerLoop(Pf4, Qf4) ∈ Gt/Fp12.
///
/// MultiPairing chekcs circuit in the "3P_2F" mode is used for triple pairs and double fixed G2
/// MultiPairing checks circuit in the "3P_2F" mode is used for triple pairs and double fixed G2
/// points
///
/// Qf1 and Qf2 are represented by their pre-computed line functions for the specifc miller loop
/// Qf1 and Qf2 are represented by their pre-computed line functions for the specific miller loop
/// implementation.
///
/// Two functions are provided for BN254 and BLS12-381 respectively.
Expand Down Expand Up @@ -47,7 +47,7 @@ use garaga::utils::{u384_assert_zero, usize_assert_eq};
use garaga::utils::hashing;


// Groth16 proof structure, genric for both BN254 and BLS12-381.
// Groth16 proof structure, generic for both BN254 and BLS12-381.
#[derive(Drop, Serde)]
pub struct Groth16Proof {
pub a: G1Point,
Expand Down
2 changes: 1 addition & 1 deletion src/src/pairing_check.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/// This file contains utilities to verify a pairing check of the form :
/// e(P1, Qf1) * e(P2, Qf2) == 1, where Qf1 and Qf2 are fixed known points. (2P_2F circuits are used
/// for double pairs and double fixed G2 points)
/// Qf1 and Qf2 are represented by their pre-computed line functions for the specifc miller loop
/// Qf1 and Qf2 are represented by their pre-computed line functions for the specific miller loop
/// implementation.
/// Two functions are provided for BN254 and BLS12-381 respectively.
/// To generate the lines functions, you can use garaga's python backend.
Expand Down