-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Check config hash and ProgramInfoChanged event #18
feat : Check config hash and ProgramInfoChanged event #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, welcome! If you can rebase / resolve conflicts ( I merged the other ProgramInfo PR ), then add the config hash functionality ( set, get, events, ... ) from the Solidity side that would be a good next step.
I think we also want to have a config hash check in updateState like here https://github.com/starkware-libs/cairo-lang/blob/ab6d079f0265f903630aac9287e93d9e7cfb6fcf/src/starkware/starknet/solidity/Starknet.sol#L209 as part of this issue.
0ade202
to
eab2dad
Compare
Hey, I resolved conflicts. To make sure I understand your request, a getter and setter for the config hash specifically is needed in addition to the When it comes to the config hash check i think the following snippet from the appchain
Let me know :) |
Maybe just the program_info is fine for now, so no worries.
👍 |
Hello first PR ever here, not sure if I needed to make a test (similar PRs haven't seemed to do it).
I implemented the ProgramInfoChanged event also related to issue #5 and discussed in PR #13