add full block 91721 test

keep-starknet-strange · Oct 15, 2024 · e912c55 · e912c55
1 parent 349909c
commit e912c55
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/consensus/src/validation/block.cairo b/packages/consensus/src/validation/block.cairo
@@ -2,10 +2,10 @@
 use crate::types::utxo_set::{UtxoSet, UtxoSetTrait};
 use crate::types::transaction::{OutPoint, Transaction};
 use crate::codec::{Encode, TransactionCodec};
+use crate::validation::coinbase::is_coinbase_txid_duplicated;
 use utils::{hash::Digest, merkle_tree::merkle_root, double_sha256::double_sha256_byte_array,};
 use super::transaction::validate_transaction;
 use core::num::traits::zero::Zero;
-use crate::validation::coinbase::is_coinbase_txid_duplicated;
 
 const MAX_BLOCK_WEIGHT_LEGACY: usize = 1_000_000;
 const MAX_BLOCK_WEIGHT: usize = 4_000_000;

diff --git a/packages/consensus/src/validation/coinbase.cairo b/packages/consensus/src/validation/coinbase.cairo
@@ -205,15 +205,15 @@ mod tests {
     #[test]
     fn test_bip30_first_txid_dup() {
         let txid: Digest = FIRST_DUP_TXID.into();
-        assert!(is_coinbase_txid_duplicated(txid, 91722));
-        assert!(!is_coinbase_txid_duplicated(txid, 91880));
+        assert!(!is_coinbase_txid_duplicated(txid, 91722));
+        assert!(is_coinbase_txid_duplicated(txid, 91880));
     }
 
     #[test]
     fn test_bip30_second_txid_dup() {
         let txid: Digest = SECOND_DUP_TXID.into();
-        assert!(is_coinbase_txid_duplicated(txid, 91812));
-        assert!(!is_coinbase_txid_duplicated(txid, 91842));
+        assert!(!is_coinbase_txid_duplicated(txid, 91812));
+        assert!(is_coinbase_txid_duplicated(txid, 91842));
     }
 
     // Ref implementation here:

diff --git a/scripts/data/regenerate_tests.sh b/scripts/data/regenerate_tests.sh
@@ -22,6 +22,7 @@ light_test_cases=(
     32255   # First target adjustment (32256)
     57042   # Block containing pizza tx (57043)
     72575   # Difficulty adjustment
+    91721   # Duplicate coinbase txid (91722)
     116927  # Difficulty adjustment
     150012  # Small Block (150013)
     209999  # First halving block (210000)
@@ -45,6 +46,7 @@ full_test_cases=(
     32255   # First target adjustment (32256)
     57042   # Block containing pizza tx (57043)
     72575   # Difficulty adjustment
+    91721   # Duplicate coinbase txid (91722)
     116927  # Difficulty adjustment
     150012  # Small Block (150013)
     209999  # First halving block (210000)