-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Provide cache hints via the data generation script #150
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6143460
to
5e50e80
Compare
I did not test the code yet, since I dont really know how to do it. Can someone help me with that a little bit? |
You will need access to the node. Contact me on tg. Right now your pr seems to contain only stylistic changes. It would be better to merge it before you start making substantive changes. @m-kus are you fine with this style? |
@maciejka adding linter would be definitely great! I'm ok with the changes, we lacked consistency wrt quotes. But having this automated would help @Gerson2102 all good, but you have to do another pass and update both outputs and outpoints in the How this will work on the Cairo side:
|
5e50e80
to
ceadb5b
Compare
So... I have to do some Cairo logic for this? Or just the python code? I dont get that part related to Cairo, or u just said it because I need to implement that on python? |
@Gerson2102 no need to implement Cairo logic here, it is just for the context so that you better understand what is it for. You just need to implement the Python part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @m-kus
@Gerson2102 fix conflicts, please. |
b6eeeb1
to
644144b
Compare
Conflicts fixed |
Adding the cache hints for outpoint transactions. I did not test the code yet.