Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Batch deletions from Utreexo accumulator #253

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

Groxan
Copy link
Contributor

@Groxan Groxan commented Oct 9, 2024

This PR includes implementation of batch deletion for StumpUtreexoAccumulator, according to the reference implementation in rustreexo.

@Groxan Groxan requested review from m-kus and maciejka as code owners October 9, 2024 14:48
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 2:36pm

packages/utils/src/bits.cairo Outdated Show resolved Hide resolved
@m-kus
Copy link
Collaborator

m-kus commented Oct 14, 2024

@Groxan pls rebase and extend the stump verification.
It might make sense to introduce a smarter wrapper for provided/computed nodes/positions (not get_next but maybe a struct or smth like that) to reduce complexity.

@Groxan
Copy link
Contributor Author

Groxan commented Oct 17, 2024

@m-kus I've reimplemented verification in a more efficient way (also added more advanced test cases) and reimplemented deletion, using the new algorithm. Since deletion actually includes verification, I called it verify_and_delete.

p.s. I didn't remove the existing verification, but moved it to verify_legacy, in case it may be needed in the future

@m-kus
Copy link
Collaborator

m-kus commented Oct 17, 2024

Thanks! Great job 👍

@m-kus m-kus merged commit 9ae2c17 into keep-starknet-strange:main Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Batch deletions from Utreexo accumulator
2 participants