Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip coinbase #294

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: skip coinbase #294

merged 2 commits into from
Nov 5, 2024

Conversation

maciejka
Copy link
Collaborator

@maciejka maciejka commented Nov 5, 2024

Skip coinbase transaction when verifying scripts.

@maciejka maciejka requested a review from m-kus as a code owner November 5, 2024 12:20
@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:20am

m-kus
m-kus approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@m-kus m-kus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could get rid of the slice if validate_script was called inside the main transaction validation loop :)

@maciejka maciejka mentioned this pull request Nov 5, 2024
Closed
@maciejka maciejka merged commit bf4b89d into main Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kus m-kus m-kus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejka @m-kus