-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/issue11 compute total work function #34
Merged
maciejka
merged 17 commits into
keep-starknet-strange:main
from
oluwa-peski:feat/issue11-compute-total-work-function
Aug 9, 2024
Merged
Feat/issue11 compute total work function #34
maciejka
merged 17 commits into
keep-starknet-strange:main
from
oluwa-peski:feat/issue11-compute-total-work-function
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oluwa-peski
requested review from
b-j-roberts,
m-kus and
maciejka
as code owners
August 6, 2024 20:23
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…thub.com/olufemi-olumaiyegun/raito into feat/issue11-compute-total-work-function
maciejka
requested changes
Aug 6, 2024
-use u256 for operations instead of i157 -copy zkSync version of tests
maciejka
requested changes
Aug 7, 2024
m-kus
reviewed
Aug 7, 2024
maciejka
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix conflicts
fixed em |
maciejka
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute_total_work
Function #11Implement compute_total_work function.
Acceptance Criteria:
implement body of the function based on ZeroSync version
write unit tests