-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Using scarb get_block
to generate test blocks
#52
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
scarb get_block
generate test blocksscarb get_block
to generate test blocks
@maciejka I guess we should wait for a correct script before merging this, so that all blocks after segwit contain correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, these files are huge. How compiler behaves? I am not sure what will happen to tests execution time if we include all of them.
@@ -5,7 +5,7 @@ def txin_coinbase: | |||
previous_output: OutPoint { | |||
txid: 0_u256, | |||
vout: 0xffffffff_u32, | |||
txo_index: 0, // TODO: implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of the comment was to make it clear that it is not fully implemented.
It is ok to merge work in progress. We will regenerate if necessary. |
@maciejka dont know for the compile for now, repo was not correctly structured regarding If thats ok for you i'll close this PR, and open a new one. |
scarb get_block
generate test blocks #51Includes:
Block 0 and Block of first p2p tx to Hal Finney were already added, now we have 13 blocks.
@maciejka if you have any idea of other blocks I could add
I removed the
// TODO: implement
in the block_filter.jq file so that it doesnt appear in all theTxIn
of Transactions contained in generated blocks.