[feat] Try to optimize merkle_tree::merkle_root #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jeanmichel7
changed the title
TAdev0
reviewed
Aug 12, 2024
| use core::num::traits::{Zero, One, BitSize}; | ||
| use core::starknet::secp256_trait::Secp256PointTrait; | ||
| use starknet::{SyscallResult, SyscallResultTrait}; |
There was a problem hiding this comment.
why would you copy paste all this from the corelib?
maciejka
reviewed
Aug 12, 2024
|
|
||
| pub fn double_sha256(a: u256, b: u256) -> u256 { | ||
| let mut ba = Default::default(); | ||
| pub fn double_sha256(inputs: Box<[u32; 16]>) -> [u32; 8] { |
There was a problem hiding this comment.
How faster is using syscall directly? Can you give any measurements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merkle_tree::merkle_root#50I tried to improve performance by rewriting compute_sha256_u32_array to be more specific to our use case.