Skip to content

Commit

Permalink
use hint_tool instead of check-orphans script
Browse files Browse the repository at this point in the history
  • Loading branch information
ftheirs committed Dec 23, 2024
1 parent 626818b commit daea7d2
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 17 deletions.
21 changes: 12 additions & 9 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: "Install cairo-lang"
run: |
# We need to pin the version of sympy, 1.13.0 is incompatible with cairo-lang
pip install cairo-lang==0.13.2 "sympy<1.13.0"
pip install cairo-lang==0.13.3 "sympy<1.13.0"
- name: "Prepare test environment"
run: |
mkdir -p build
Expand All @@ -53,7 +53,7 @@ jobs:
- name: "Install cairo-lang"
run: |
# We need to pin the version of sympy, 1.13.0 is incompatible with cairo-lang
pip install cairo-lang==0.13.2 "sympy<1.13.0"
pip install cairo-lang==0.13.3 "sympy<1.13.0"
- name: "Prepare test environment"
run: |
bash ./setup-scripts/reset-tests.sh
Expand Down Expand Up @@ -89,10 +89,13 @@ jobs:
orphans:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: rustup show
- run: rustup component add rustfmt
- uses: Swatinem/rust-cache@v2
- run: git submodule update --init
- run: ./scripts/check-orphans.sh

- name: Checkout code
uses: actions/checkout@v3
- name: Check orphaned hints
run: |
RESULT=$(cargo run --release -p hint_tool -- --subset orphaned | grep -oP '\d+$')
# Only 1 orphan allow (breakpoint hint)
if [ "$RESULT" -gt 1 ]; then
echo "Error: more than 1 orphaned hints found."
exit 1
fi
2 changes: 1 addition & 1 deletion crates/bin/hint_tool/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ struct Args {

/// Input JSON file (e.g. "os_latest.json")
#[arg(long)]
#[clap(default_value = Some("../../build/os_latest.json"))]
#[clap(default_value = Some("build/os_latest.json"))]
in_file: PathBuf,
}

Expand Down
7 changes: 0 additions & 7 deletions scripts/check-orphans.sh

This file was deleted.

0 comments on commit daea7d2

Please sign in to comment.