Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use Arc instead of Rc in GenericFoo structs #372

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix: Use Arc instead of Rc in GenericFoo structs #372

merged 1 commit into from
Sep 16, 2024

Conversation

notlesh
Copy link
Collaborator

@notlesh notlesh commented Sep 13, 2024

Problem: prove_block can't be used across threads because some structs internally use Rc.

Solution: Replace Rc with Arc.

This supercedes #368 as part of fixing #364.

Issue Number: #364

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

@notlesh notlesh requested a review from odesenfans as a code owner September 13, 2024 17:09
@notlesh notlesh mentioned this pull request Sep 13, 2024
Closed
9 tasks
@notlesh notlesh merged commit 322eb04 into main Sep 16, 2024
6 checks passed
@notlesh notlesh deleted the notlesh/arc-instead-of-rc-for-generic-foo branch September 16, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whichqua whichqua whichqua approved these changes

@odesenfans odesenfans Awaiting requested review from odesenfans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notlesh @whichqua