Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buggy ptr inget_tx_info syscall inside validate_declare for account contracts #441

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

whichqua
Copy link
Collaborator

@whichqua whichqua commented Nov 28, 2024

Issue Number: #437

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

@whichqua whichqua marked this pull request as ready for review November 29, 2024 11:52
Copy link
Collaborator

@GMKrieger GMKrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Collaborator

@ftheirs ftheirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 😎

Copy link
Collaborator

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ptr strikes again...

@whichqua whichqua changed the title fix: Memory Addresses must be relocatable fix: get_tx_info in validate_declare Dec 3, 2024
@whichqua whichqua changed the title fix: get_tx_info in validate_declare fix: buggy ptr inget_tx_info syscall inside validate_declare for account contracts Dec 3, 2024
@ftheirs ftheirs merged commit 35a300a into main Dec 12, 2024
6 checks passed
@ftheirs ftheirs deleted the gm/fix-addresses-not-relocatable branch December 12, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants