Add load_bottom hint test #444
Merged
+42
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whichqua
approved these changes
Dec 2, 2024
whichqua
reviewed
Dec 2, 2024
GMKrieger
force-pushed
the
test/starknet-os-hints
branch
from
56e78d2 to
9b2c722
Compare
notlesh
reviewed
Dec 3, 2024
Comment on lines
+570
to
+574
| let expected_x: Felt252 = 2_usize.into(); | ||
| let expected_y: Felt252 = 3_usize.into(); | ||
|
|
||
| assert_eq!(x.to_raw(), expected_x.to_raw()); | ||
| assert_eq!(y.to_raw(), expected_y.to_raw()); |
There was a problem hiding this comment.
There are some useful constants you could use (Felt252::TWO and Felt252::THREE)
notlesh
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: N/A
Type
Description
Add new test for
state.rsload_bottom hint.Breaking changes?