Dict hints #455
Merged
Dict hints #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whichqua
reviewed
Jan 2, 2025
crates/starknet-os/src/hints/dict.rs
Outdated
|
|
||
| let bucket_index = get_maybe_relocatable_from_var_name(vars::ids::BUCKET_INDEX, vm, ids_data, ap_tracking)?; | ||
|
|
||
| let prev_offset = dict_tracker.get(&bucket_index).unwrap().clone(); |
There was a problem hiding this comment.
Handling this unwrap is the only thing I can thing of.
notlesh
requested changes
Jan 6, 2025
There was a problem hiding this comment.
The code looks good to me, but I would suggest one thing:
In cairo-lang this all comes from a file called compression.cairo, and we have tried to keep our file structure similar to theirs. So, my suggestions:
- Rename
dict.rs->compression.rs - Drop
constants.rsand include its contents incompression.rs
notlesh
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement dictionary hints related to compression process.
Add constants.rs file to define constants that are needed across several hints
KZG tests still require extra hints.
Check orphan hints is failing because it detects two extra hints that will be covered in compress PR (
COMPRESSandSET_DECOMPRESSED_DST)Issue Number: N/A
Type
Description
Breaking changes?