Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some tests for is_valid_signature #121

Merged

Conversation

Gerson2102
Copy link
Contributor

This PR is adding some tests for the is_valid_signature function. Still work in progress.

@Gerson2102
Copy link
Contributor Author

For the empty signature case. I'm getting this as a value when I run the test:

[FAIL] tests::test_account::test_empty_signature

Failure data:
    0x696e76616c6964207369676e6174757265 ('invalid signature')

And in the test I'm comparing the value to 'invalid signature' but it seems that is not catching it. I dont know how that works.

@Gerson2102
Copy link
Contributor Author

The test_is_not_valid_signature is working fine. But I dont know how to do a test that checks that the signature is working fine. Or the function is working as expected. Is there any resource that could be shared with me to see how to do that?

@Gerson2102 Gerson2102 force-pushed the test-valid-signature branch from eea301c to 1db494a Compare November 2, 2024 03:52
@trbutler4
Copy link
Collaborator

Contributor

thats fine

Copy link
Collaborator

@trbutler4 trbutler4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@trbutler4 trbutler4 merged commit 8ca6d6d into keep-starknet-strange:main Nov 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants